]> xenbits.xensource.com Git - people/tklengyel/xen.git/commitdiff
libxl: do not call libxl__file_reference_unmap twice
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 11 Feb 2011 17:53:08 +0000 (17:53 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 11 Feb 2011 17:53:08 +0000 (17:53 +0000)
Fix double free due to libxl__file_reference_unmap(&info->kernel) called
multiple times: first at the end of libxl__domain_build and then in
libxl_domain_build_info_destroy.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_create.c

index 3ee667282025fb4cd108720ee3f4cec753a0f92d..260d3c0a91319ae7302d9d5ebbd82969e1d4e235 100644 (file)
@@ -196,9 +196,6 @@ int libxl__domain_build(libxl_ctx *ctx, libxl_domain_build_info *info, uint32_t
     }
     ret = libxl__build_post(ctx, domid, info, state, vments, localents);
 out:
-    libxl__file_reference_unmap(&info->kernel);
-    if (!info->hvm)
-           libxl__file_reference_unmap(&info->u.pv.ramdisk);
 
     libxl__free_all(&gc);
     return ret;