]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
plugins: Fix physical address calculation for IO regions
authorAaron Lindsay <aaron@os.amperecomputing.com>
Tue, 20 Jul 2021 23:26:58 +0000 (00:26 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Fri, 23 Jul 2021 16:22:16 +0000 (17:22 +0100)
The address calculation for IO regions introduced by

commit 787148bf928a54b5cc86f5b434f9399e9737679c
Author: Aaron Lindsay <aaron@os.amperecomputing.com>
    plugins: Expose physical addresses instead of device offsets

is not always accurate. Use the more correct
MemoryRegionSection.offset_within_address_space.

Signed-off-by: Aaron Lindsay <aaron@os.amperecomputing.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210720195735.3934473-1-aaron@os.amperecomputing.com>
Message-Id: <20210720232703.10650-25-alex.bennee@linaro.org>

plugins/api.c

index 78b563c5c51a78c29f6699c1897e8e775d589ea8..2d521e6ba82510a9f119a0283cc12046dfedfaf0 100644 (file)
@@ -319,7 +319,7 @@ uint64_t qemu_plugin_hwaddr_phys_addr(const struct qemu_plugin_hwaddr *haddr)
             return block->offset + offset + block->mr->addr;
         } else {
             MemoryRegionSection *mrs = haddr->v.io.section;
-            return haddr->v.io.offset + mrs->mr->addr;
+            return mrs->offset_within_address_space + haddr->v.io.offset;
         }
     }
 #endif