]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
msix: Note endian TODO item
authorAlex Williamson <alex.williamson@redhat.com>
Thu, 14 Jun 2012 18:16:28 +0000 (12:16 -0600)
committerMichael S. Tsirkin <mst@robin.(none)>
Mon, 18 Jun 2012 07:21:11 +0000 (10:21 +0300)
MSIX, like PCI, is little endian.  Specifying native is wrong here,
but we need to check the rest of the file to determine if it's
as simple as flipping this macro.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/msix.c

index 50885acb91f77320626bb6be705813b1f89240a6..87d316a580fe88a706d1679339a744d2c0ba4f75 100644 (file)
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr,
 static const MemoryRegionOps msix_mmio_ops = {
     .read = msix_mmio_read,
     .write = msix_mmio_write,
+    /* TODO: MSIX should be LITTLE_ENDIAN. */
     .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,