]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu_snapshot: revert: remove cleanup label
authorPavel Hrdina <phrdina@redhat.com>
Thu, 25 Nov 2021 16:08:35 +0000 (17:08 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Fri, 3 Dec 2021 11:00:30 +0000 (12:00 +0100)
Now the cleanup label is not necessary so we can drop it.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_snapshot.c

index 8191733a6dfe9b46ea6404fa527dac248af3a867..beeb012431a65bd7e54c56a773d3ae81f7e67571 100644 (file)
@@ -1967,13 +1967,13 @@ qemuSnapshotRevert(virDomainObj *vm,
     if (qemuDomainHasBlockjob(vm, false)) {
         virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                        _("domain has active block job"));
-        goto cleanup;
+        return -1;
     }
 
     if (qemuProcessBeginJob(driver, vm,
                             VIR_DOMAIN_JOB_OPERATION_SNAPSHOT_REVERT,
                             flags) < 0)
-        goto cleanup;
+        return -1;
 
     if (!(snap = qemuSnapObjFromSnapshot(vm, snapshot)))
         goto endjob;
@@ -2210,7 +2210,6 @@ qemuSnapshotRevert(virDomainObj *vm,
  endjob:
     qemuProcessEndJob(driver, vm);
 
- cleanup:
     if (ret == 0) {
         qemuSnapshotSetCurrent(vm, snap);
         if (qemuDomainSnapshotWriteMetadata(vm, snap,