]> xenbits.xensource.com Git - people/iwj/xen.git/commitdiff
tools/ocaml/libs/xc fix gcc-8 format-truncation warning
authorJohn Thomson <git@johnthomson.fastmail.com.au>
Tue, 15 May 2018 01:48:43 +0000 (11:48 +1000)
committerWei Liu <wei.liu2@citrix.com>
Wed, 16 May 2018 08:19:21 +0000 (09:19 +0100)
 CC       xenctrl_stubs.o
xenctrl_stubs.c: In function 'failwith_xc':
xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
      "%d: %s: %s", error->code,
                 ^
xenctrl_stubs.c:64:4: note: 'snprintf' output 6 or more bytes (assuming 1029) into a destination of size 1028
    snprintf(error_str, sizeof(error_str),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "%d: %s: %s", error->code,
      ~~~~~~~~~~~~~~~~~~~~~~~~~~
      xc_error_code_to_desc(error->code),
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      error->message);
      ~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[8]: *** [/build/xen-git/src/xen/tools/ocaml/libs/xc/../../Makefile.rules:37: xenctrl_stubs.o] Error 1
m

Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
tools/ocaml/libs/xc/xenctrl_stubs.c

index f97070c8b040503a56cb1e9db61207a626f3645e..d4309ad97e68a26e977788369076ed24cd82299e 100644 (file)
@@ -54,7 +54,7 @@
 
 static void Noreturn failwith_xc(xc_interface *xch)
 {
-       char error_str[1028];
+       char error_str[XC_MAX_ERROR_MSG_LEN + 6];
        if (xch) {
                const xc_error *error = xc_get_last_error(xch);
                if (error->code == XC_ERROR_NONE)