]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Don't ignore XMLParseAllowReboot() errors
authorAndrea Bolognani <abologna@redhat.com>
Thu, 24 Mar 2022 18:48:08 +0000 (19:48 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Tue, 5 Apr 2022 11:40:30 +0000 (13:40 +0200)
The function may fail and report an error, in which case we
should not just continue as if nothing happened.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_domain.c

index 820a6a8a61e1966a6f70973576a242552b4fbc0e..fe00c6f25b5d4c7fcefc9d1c12b4093a134b84ab 100644 (file)
@@ -3106,7 +3106,8 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt,
     priv->chardevStdioLogd = virXPathBoolean("boolean(./chardevStdioLogd)",
                                              ctxt) == 1;
 
-    qemuDomainObjPrivateXMLParseAllowReboot(ctxt, &priv->allowReboot);
+    if (qemuDomainObjPrivateXMLParseAllowReboot(ctxt, &priv->allowReboot) < 0)
+        goto error;
 
     qemuDomainObjPrivateXMLParsePR(ctxt, &priv->prDaemonRunning);