]> xenbits.xensource.com Git - libvirt.git/commitdiff
vz: use state variable sdkdom in prlsdkApplyConfig
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Wed, 20 Jul 2016 15:00:30 +0000 (18:00 +0300)
committerMaxim Nestratov <mnestratov@virtuozzo.com>
Wed, 20 Jul 2016 21:59:17 +0000 (00:59 +0300)
sdk domain handle is unique per connection so there is
no sense to query it again if we have it in vzDomObjPtr.
Side effect of prlsdkSdkDomainLookupByUUID is refreshing
domain config is of no use too as PrlVm_BeginEdit do it too.

src/vz/vz_sdk.c

index 5e36a8b1e8c372ffba831885d39bd13b4e53cb55..6b5adbf96babe272947b86d3bd3aeff9e09a336f 100644 (file)
@@ -3906,28 +3906,22 @@ prlsdkApplyConfig(vzDriverPtr driver,
                   virDomainObjPtr dom,
                   virDomainDefPtr new)
 {
-    PRL_HANDLE sdkdom = PRL_INVALID_HANDLE;
+    vzDomObjPtr privdom = dom->privateData;
     PRL_HANDLE job = PRL_INVALID_HANDLE;
     int ret;
 
-    sdkdom = prlsdkSdkDomainLookupByUUID(driver, dom->def->uuid);
-    if (sdkdom == PRL_INVALID_HANDLE)
-        return -1;
-
-    job = PrlVm_BeginEdit(sdkdom);
+    job = PrlVm_BeginEdit(privdom->sdkdom);
     if (PRL_FAILED(waitJob(job)))
         return -1;
 
-    ret = prlsdkDoApplyConfig(driver, sdkdom, new, dom->def);
+    ret = prlsdkDoApplyConfig(driver, privdom->sdkdom, new, dom->def);
 
     if (ret == 0) {
-        job = PrlVm_CommitEx(sdkdom, PVCF_DETACH_HDD_BUNDLE);
+        job = PrlVm_CommitEx(privdom->sdkdom, PVCF_DETACH_HDD_BUNDLE);
         if (PRL_FAILED(waitJob(job)))
             ret = -1;
     }
 
-    PrlHandle_Free(sdkdom);
-
     return ret;
 }