step status skip: Implement in sg-report-flight

* When we are doing archaeology, searching for flight(s) which ran a
  particular testid, ignore all flights where the testid was skipped.

* In a flight we are examining for failures we need to justify, do not
  regard `skip' as a failure which requires investigation.  We
  thusg treat `skip' in such a flight very like `pass'.

* Assign a colour (dark grey, almost like the background) and display
  priority (very low) to `skip', so that they turn up nicely in the
  HTML grids.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

diff --git a/sg-report-flight b/sg-report-flight
index ca9ba18b53f1ddc9f207238321a42b2ece0d2cce..dbb17bea2e651fff5be1bcf0603a08535c65f4b7 100755 (executable)
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -162,6 +162,7 @@ sub findaflight ($$$$$) {
 
     my $checkq= db_prepare(<<END);
         SELECT status FROM steps WHERE flight=? AND job=? AND testid=?
+                                   AND status!='skip'
 END
 
     my $thatflight= $specver{that}{flight};
@@ -460,7 +461,7 @@ END
 
             my $fi= { Job => $j, Step => $s };
             
-            if ($s->{status} ne 'pass') {
+            if ($s->{status} ne 'pass' && $s->{status} ne 'skip') {
                 $fi= $storefail->($s);
                 $foundfail= 1;
             }
@@ -1083,7 +1084,8 @@ END
 
 sub html_status2_colour_priority ($) {
     my ($st) = @_;
-    return ($st eq 'pass' ? ('#008800',100) :
+    return ($st eq 'skip' ? ('#555555', 50) :
+            $st eq 'pass' ? ('#008800',100) :
             $st eq 'fail' ? ('#ff8888',200) :
             $st eq 'running' ? ('#666666',250) :
             ('#ffff00',300));