]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Don't require gawk for a simple print expression
authorGuido Günther <agx@sigxcpu.org>
Tue, 28 Aug 2012 08:57:54 +0000 (10:57 +0200)
committerDaniel Veillard <veillard@redhat.com>
Wed, 29 Aug 2012 04:00:03 +0000 (12:00 +0800)
Fedora uses gawk as awk so there's no change and in behavior while
Debian/Ubuntu use mawk by default.

This was reported by Luca Capello in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636712

src/nwfilter/nwfilter_ebiptables_driver.c

index 11fd04c366228c0ed4adf11e874d0d2fd5e8d38e..ad1d0555ebf40448b494ab32fc8c1faffb4ea6fe 100644 (file)
@@ -84,7 +84,7 @@ static char *ebtables_cmd_path;
 static char *iptables_cmd_path;
 static char *ip6tables_cmd_path;
 static char *grep_cmd_path;
-static char *gawk_cmd_path;
+static char *awk_cmd_path;
 
 #define PRINT_ROOT_CHAIN(buf, prefix, ifname) \
     snprintf(buf, sizeof(buf), "libvirt-%c-%s", prefix, ifname)
@@ -586,7 +586,7 @@ static int iptablesLinkIPTablesBaseChain(virBufferPtr buf,
                       grep_cmd_path, udchain,
 
                       syschain, pos, udchain,
-                      gawk_cmd_path,
+                      awk_cmd_path,
 
                       pos,
 
@@ -4288,7 +4288,7 @@ ebiptablesDriverInit(bool privileged)
     if (virMutexInit(&execCLIMutex) < 0)
         return -EINVAL;
 
-    gawk_cmd_path = virFindFileInPath("gawk");
+    awk_cmd_path = virFindFileInPath("awk");
     grep_cmd_path = virFindFileInPath("grep");
 
     /*
@@ -4302,9 +4302,9 @@ ebiptablesDriverInit(bool privileged)
     /* make sure tools are available and work */
     ebiptablesDriverTestCLITools();
 
-    /* ip(6)tables support needs gawk & grep, ebtables doesn't */
+    /* ip(6)tables support needs awk & grep, ebtables doesn't */
     if ((iptables_cmd_path != NULL || ip6tables_cmd_path != NULL) &&
-        (!grep_cmd_path || !gawk_cmd_path)) {
+        (!grep_cmd_path || !awk_cmd_path)) {
         VIR_ERROR(_("essential tools to support ip(6)tables "
                   "firewalls could not be located"));
         VIR_FREE(iptables_cmd_path);
@@ -4326,7 +4326,7 @@ ebiptablesDriverInit(bool privileged)
 static void
 ebiptablesDriverShutdown(void)
 {
-    VIR_FREE(gawk_cmd_path);
+    VIR_FREE(awk_cmd_path);
     VIR_FREE(grep_cmd_path);
     VIR_FREE(ebtables_cmd_path);
     VIR_FREE(iptables_cmd_path);