]> xenbits.xensource.com Git - libvirt.git/commitdiff
remote_daemon_dispatch: Don't leak @ret on failure
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 27 Aug 2019 09:47:52 +0000 (11:47 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 28 Aug 2019 09:19:10 +0000 (11:19 +0200)
If there's a problem in encoding @ret (for instance
virTypedParamsSerialize() fails) then @ret is leaked.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/remote/remote_daemon_dispatch.c

index e205c743c3826382ca3e96dcc0a32b8c3408406e..c658a6e115d56e9f2d97a2e98d60a6ac65954207 100644 (file)
@@ -7025,8 +7025,11 @@ remoteDispatchConnectGetAllDomainStats(virNetServerPtr server ATTRIBUTE_UNUSED,
     rv = 0;
 
  cleanup:
-    if (rv < 0)
+    if (rv < 0) {
         virNetMessageSaveError(rerr);
+        xdr_free((xdrproc_t)xdr_remote_connect_get_all_domain_stats_ret,
+                 (char *) ret);
+    }
 
     virDomainStatsRecordListFree(retStats);
     virObjectListFree(doms);