]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
tulip: Remove unused variable
authorMiroslav Rezanina <mrezanin@redhat.com>
Wed, 9 Nov 2022 15:57:12 +0000 (10:57 -0500)
committerAnthony PERARD <anthony.perard@citrix.com>
Mon, 17 Jul 2023 11:05:00 +0000 (12:05 +0100)
Variable n used in tulip_idblock_crc function is only incremented but never read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.

Removing the variable to prevent the warning.

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <02e1560d115c208df32236df8916fed98429fda1.1668009030.git.mrezanin@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
(cherry picked from commit 6083dcad80743718620a3f8a72fb76ea8b7c28ca)

hw/net/tulip.c

index ca69f7ea5e17785afda221ddb6fe07242d16a149..42666378de84ad6260c28fb5df6eaee2275ce468 100644 (file)
@@ -866,11 +866,10 @@ static const MemoryRegionOps tulip_ops = {
 
 static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
 {
-    int word, n;
+    int word;
     int bit;
     unsigned char bitval, crc;
     const int len = 9;
-    n = 0;
     crc = -1;
 
     for (word = 0; word < len; word++) {
@@ -883,7 +882,6 @@ static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
                 srom[len - 1] = (srom[len - 1] & 0xff00) | (unsigned short)crc;
                 break;
             }
-            n++;
             bitval = ((srom[word] >> bit) & 1) ^ ((crc >> 7) & 1);
             crc = crc << 1;
             if (bitval == 1) {