]> xenbits.xensource.com Git - xen.git/commitdiff
xen/arm: alternative: Remove unused parameter for alternative_if_not_cap
authorJulien Grall <julien.grall@arm.com>
Mon, 23 Sep 2019 16:55:49 +0000 (17:55 +0100)
committerStefano Stabellini <sstabellini@kernel.org>
Wed, 27 Nov 2019 22:31:26 +0000 (14:31 -0800)
The macro alternative_if_not_cap is taking two parameters. The second
parameter is never used and it is hard to see how this can be used
correctly as it is only protecting the alternative section magic.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr.babchuk@epam.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Release-acked-by: Juergen Gross <jgross@suse.com>
xen/include/asm-arm/alternative.h

index dedb6dd00166d6bec9c9f54a66e576dc18d50952..2830a6da2df3dc447a6be79b0f75c186b93d8c3e 100644 (file)
@@ -116,13 +116,11 @@ int apply_alternatives(const struct alt_instr *start, const struct alt_instr *en
  * The code that follows this macro will be assembled and linked as
  * normal. There are no restrictions on this code.
  */
-.macro alternative_if_not cap, enable = 1
-       .if \enable
+.macro alternative_if_not cap
        .pushsection .altinstructions, "a"
        altinstruction_entry 661f, 663f, \cap, 662f-661f, 664f-663f
        .popsection
 661:
-       .endif
 .endm
 
 /*