]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
rtc: test: Fix invalid format specifier.
authorDavid Gow <davidgow@google.com>
Wed, 21 Feb 2024 09:27:18 +0000 (17:27 +0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:20:29 +0000 (18:20 -0400)
[ Upstream commit 8a904a3caa88118744062e872ae90f37748a8fd8 ]

'days' is a s64 (from div_s64), and so should use a %lld specifier.

This was found by extending KUnit's assertion macros to use gcc's
__printf attribute.

Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add tests.")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/lib_test.c

index d5caf36c56cdcfdfdc22537de70cd5ab44b1644c..225c859d6da550a8cb44c3d2446f3d433c9716e3 100644 (file)
@@ -54,7 +54,7 @@ static void rtc_time64_to_tm_test_date_range(struct kunit *test)
 
                days = div_s64(secs, 86400);
 
-               #define FAIL_MSG "%d/%02d/%02d (%2d) : %ld", \
+               #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \
                        year, month, mday, yday, days
 
                KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);