]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
gtk: Don't vte_terminal_set_encoding() on new VTE versions
authorKevin Wolf <kwolf@redhat.com>
Thu, 11 Oct 2018 15:30:39 +0000 (17:30 +0200)
committerAnthony PERARD <anthony.perard@citrix.com>
Mon, 1 Apr 2019 15:20:24 +0000 (16:20 +0100)
The function vte_terminal_set_encoding() is deprecated since VTE 0.54,
so stop calling it from that version on. This fixes a build error
because of our use of warning flags [-Werror=deprecated-declarations].

Fixes: https://bugs.launchpad.net/bugs/1794939
Reported-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 20181011153039.2324-1-kwolf@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 6415994ffcc6d22b3f5add67f63fe77e4b9711f4)

ui/gtk.c

index 342e96fbe9358192155159ff02acd1fcdb533b9f..9076d25045ad0195f5747d48e925ec84b113f8c7 100644 (file)
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1831,12 +1831,14 @@ static GSList *gd_vc_vte_init(GtkDisplayState *s, VirtualConsole *vc,
     g_signal_connect(vc->vte.terminal, "commit", G_CALLBACK(gd_vc_in), vc);
 
     /* The documentation says that the default is UTF-8, but actually it is
-     * 7-bit ASCII at least in VTE 0.38.
-     */
+     * 7-bit ASCII at least in VTE 0.38. The function is deprecated since
+     * VTE 0.54 (only UTF-8 is supported now). */
+#if !VTE_CHECK_VERSION(0, 54, 0)
 #if VTE_CHECK_VERSION(0, 38, 0)
     vte_terminal_set_encoding(VTE_TERMINAL(vc->vte.terminal), "UTF-8", NULL);
 #else
     vte_terminal_set_encoding(VTE_TERMINAL(vc->vte.terminal), "UTF-8");
+#endif
 #endif
 
     vte_terminal_set_scrollback_lines(VTE_TERMINAL(vc->vte.terminal), -1);