]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
migration/rdma: Check qemu_rdma_init_one_block
authorDr. David Alan Gilbert <dgilbert@redhat.com>
Fri, 8 Mar 2019 18:51:24 +0000 (18:51 +0000)
committerJuan Quintela <quintela@redhat.com>
Mon, 25 Mar 2019 17:45:10 +0000 (18:45 +0100)
Actually it can't fail at the moment, but Coverity moans that
it's the only place it's not checked, and it's an easy check.

Reported-by: Coverity (CID 1399413)
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/rdma.c

index 63c118af09377f48c63201da125124f30515e723..c1bcece53bcbba8d99b04562ed75495fa0b00ef5 100644 (file)
@@ -641,10 +641,14 @@ static int qemu_rdma_init_one_block(RAMBlock *rb, void *opaque)
 static int qemu_rdma_init_ram_blocks(RDMAContext *rdma)
 {
     RDMALocalBlocks *local = &rdma->local_ram_blocks;
+    int ret;
 
     assert(rdma->blockmap == NULL);
     memset(local, 0, sizeof *local);
-    foreach_not_ignored_block(qemu_rdma_init_one_block, rdma);
+    ret = foreach_not_ignored_block(qemu_rdma_init_one_block, rdma);
+    if (ret) {
+        return ret;
+    }
     trace_qemu_rdma_init_ram_blocks(local->nb_blocks);
     rdma->dest_blocks = g_new0(RDMADestBlock,
                                rdma->local_ram_blocks.nb_blocks);