]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuBuildChrChardevStr: Rename 'flags' to 'cdevflags'
authorPeter Krempa <pkrempa@redhat.com>
Mon, 30 Nov 2020 13:14:22 +0000 (14:14 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 8 Jan 2021 08:17:26 +0000 (09:17 +0100)
The monitor code uses 'flags' for the flags of the monitor builder,
while in this function it's a different set of flags. All callers pass a
variable named 'cdevflags', so rename the argument to suit.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c

index 02f956ce484c4a30aef9f0a603c794364405b657..3e6518b96deabfb9415000a9fec0ca79cfa51cd1 100644 (file)
@@ -4756,7 +4756,7 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager,
                        const virDomainChrSourceDef *dev,
                        const char *alias,
                        virQEMUCapsPtr qemuCaps,
-                       unsigned int flags)
+                       unsigned int cdevflags)
 {
     qemuDomainChrSourcePrivatePtr chrSourcePriv = QEMU_DOMAIN_CHR_SOURCE_PRIVATE(dev);
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
@@ -4789,7 +4789,7 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager,
     case VIR_DOMAIN_CHR_TYPE_FILE:
         virBufferAsprintf(&buf, "file,id=%s", charAlias);
 
-        if (qemuBuildChrChardevFileStr(flags & QEMU_BUILD_CHARDEV_FILE_LOGD ?
+        if (qemuBuildChrChardevFileStr(cdevflags & QEMU_BUILD_CHARDEV_FILE_LOGD ?
                                        logManager : NULL,
                                        cmd, def, &buf,
                                        "path", dev->data.file.path,
@@ -4838,7 +4838,7 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager,
 
         if (dev->data.tcp.listen) {
             virBufferAddLit(&buf, ",server");
-            if (flags & QEMU_BUILD_CHARDEV_TCP_NOWAIT)
+            if (cdevflags & QEMU_BUILD_CHARDEV_TCP_NOWAIT)
                 virBufferAddLit(&buf, ",nowait");
         }
 
@@ -4878,7 +4878,7 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager,
     case VIR_DOMAIN_CHR_TYPE_UNIX:
         virBufferAsprintf(&buf, "socket,id=%s", charAlias);
         if (dev->data.nix.listen &&
-            (flags & QEMU_BUILD_CHARDEV_UNIX_FD_PASS) &&
+            (cdevflags & QEMU_BUILD_CHARDEV_UNIX_FD_PASS) &&
             virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_FD_PASS)) {
             int fd;
 
@@ -4901,7 +4901,7 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager,
         }
         if (dev->data.nix.listen) {
             virBufferAddLit(&buf, ",server");
-            if (flags & QEMU_BUILD_CHARDEV_TCP_NOWAIT)
+            if (cdevflags & QEMU_BUILD_CHARDEV_TCP_NOWAIT)
                 virBufferAddLit(&buf, ",nowait");
         }