]> xenbits.xensource.com Git - libvirt.git/commitdiff
lxc: explicitly error on interface type=ethernet
authorCole Robinson <crobinso@redhat.com>
Mon, 11 Apr 2016 14:48:20 +0000 (10:48 -0400)
committerCole Robinson <crobinso@redhat.com>
Mon, 18 Apr 2016 21:49:45 +0000 (17:49 -0400)
It isn't implemented and does not work:

error: internal error: guest failed to start: /usr/lib/libvirt/libvirt_lxc: option '--veth' requires an argument
syntax: /usr/lib/libvirt/libvirt_lxc [OPTIONS] ...

We previously threw an explicit error, but this changed in
22cff52a2b8e06c913b1f97767e5d390fb17fc3b , which I suspect was
untested for LXC

src/lxc/lxc_process.c

index 5e0bbe2801069b730bdc978c246e391c624446e7..0044ee53ba8e03ef68f6b93b2660d3cf73dfe7bb 100644 (file)
@@ -559,8 +559,6 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn,
             break;
 
         case VIR_DOMAIN_NET_TYPE_ETHERNET:
-            break;
-
         case VIR_DOMAIN_NET_TYPE_USER:
         case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
         case VIR_DOMAIN_NET_TYPE_SERVER: