]> xenbits.xensource.com Git - people/vhanquez/xen.git/commitdiff
qemu: Send unit_attention on cd-rom not_ready to ready transition
authorKeir Fraser <keir.fraser@citrix.com>
Thu, 15 May 2008 08:46:39 +0000 (09:46 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Thu, 15 May 2008 08:46:39 +0000 (09:46 +0100)
Patch sends a UNIT_ATTENTION(6), MEDIUM_MAY_HAVE_CHANGED(0x28) sense
when cdrom transitions from not ready to ready.

ATA Packet interface for CD-ROMS, SFF8020i.pdf. See state diagram
Figure 12, page 82 and Table 44 -recommended Sense Key, ASC

With patch in place HVM win2008 server guest sees the CD/DVD contents
have changed when the media is switched.

Signed-off-by: Pat Campbell <plc@novell.com>
xen-unstable changeset:   17633:a864c0c4d605efceac28106a7072aa8c1ebdea83
xen-unstable date:        Wed May 14 09:15:02 2008 +0100

tools/ioemu/hw/ide.c

index d0adad98e67dd15e2cf8c7dfff8f86bfe42983ae..bc096dc73f9c710cf1b08e7c21129ad5ae77fd0b 100644 (file)
 #define ASC_ILLEGAL_OPCODE                   0x20
 #define ASC_LOGICAL_BLOCK_OOR                0x21
 #define ASC_INV_FIELD_IN_CMD_PACKET          0x24
+#define ASC_MEDIUM_MAY_HAVE_CHANGED          0x28
 #define ASC_MEDIUM_NOT_PRESENT               0x3a
 #define ASC_SAVING_PARAMETERS_NOT_SUPPORTED  0x39
 
@@ -1406,6 +1407,11 @@ static void ide_atapi_cmd(IDEState *s)
     switch(s->io_buffer[0]) {
     case GPCMD_TEST_UNIT_READY:
         if (bdrv_is_inserted(s->bs)) {
+            if (s->is_cdrom && s->sense_key == SENSE_NOT_READY) {
+                ide_atapi_cmd_error(s, SENSE_UNIT_ATTENTION, 
+                                    ASC_MEDIUM_MAY_HAVE_CHANGED);
+                break;
+            }
             ide_atapi_cmd_ok(s);
         } else {
             ide_atapi_cmd_error(s, SENSE_NOT_READY,