]> xenbits.xensource.com Git - people/andrewcoop/xen.git/commitdiff
xen/arm: guest_walk: address violations of MISRA C:2012 Rule 16.3
authorFederico Serafini <federico.serafini@bugseng.com>
Wed, 20 Dec 2023 11:03:03 +0000 (12:03 +0100)
committerStefano Stabellini <stefano.stabellini@amd.com>
Wed, 20 Dec 2023 18:19:57 +0000 (10:19 -0800)
Add missing break statements to address violations of Rule 16.3
("An unconditional `break' statement shall terminate every
switch-clause").
No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
Acked-by: Julien Grall <jgrall@amazon.com>
xen/arch/arm/guest_walk.c

index d99b411f3b01201d324dcfd8f46db9c7a70a3c95..2f7d3a0da7d2b7f3ff4babc39445f003a6a1044c 100644 (file)
@@ -165,6 +165,8 @@ static bool guest_walk_sd(const struct vcpu *v,
             *perms |= GV2M_WRITE;
         if ( !pte.sec.xn )
             *perms |= GV2M_EXEC;
+
+        break;
     }
 
     return true;
@@ -260,6 +262,7 @@ static bool get_ttbr_and_gran_64bit(uint64_t *ttbr, unsigned int *gran,
              * fall back to 4K by default.
              */
             *gran = GRANULE_SIZE_INDEX_4K;
+            break;
         }
 
         /* Use TTBR0 for GVA to IPA translation. */
@@ -291,6 +294,7 @@ static bool get_ttbr_and_gran_64bit(uint64_t *ttbr, unsigned int *gran,
              * fall back to 4K by default.
              */
             *gran = GRANULE_SIZE_INDEX_4K;
+            break;
         }
 
         /* Use TTBR1 for GVA to IPA translation. */