]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Don't overwrite DomainSave errors
authorCole Robinson <crobinso@redhat.com>
Tue, 15 Mar 2016 19:24:10 +0000 (15:24 -0400)
committerCole Robinson <crobinso@redhat.com>
Tue, 15 Mar 2016 19:43:34 +0000 (15:43 -0400)
These functions already report fine grained errors, there's no
benefit to overwriting the error here.

src/qemu/qemu_driver.c

index edf39d93ea71a6b1080e142be17c29e29a93cca7..29c3bc8f8af7606912037d643952a4b8c06e4f59 100644 (file)
@@ -17631,11 +17631,8 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
         vm->def->disks[idx]->blkdeviotune = info;
 
         ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps);
-        if (ret < 0) {
-            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
-                           _("Saving live XML config failed"));
+        if (ret < 0)
             goto endjob;
-        }
 
         if (eventNparams) {
             event = virDomainEventTunableNewFromDom(dom, eventParams, eventNparams);
@@ -17658,11 +17655,9 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
         }
         conf_disk->blkdeviotune = info;
         ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef);
-        if (ret < 0) {
-            virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                           _("Write to config file failed"));
+        if (ret < 0)
             goto endjob;
-        }
+
     }
 
  endjob: