]> xenbits.xensource.com Git - xen.git/commitdiff
xen/grant-table: Remove outdated warning in gnttab_grow_table()
authorJulien Grall <julien@xen.org>
Tue, 25 Feb 2020 12:32:49 +0000 (12:32 +0000)
committerJulien Grall <julien@xen.org>
Thu, 5 Mar 2020 12:59:46 +0000 (12:59 +0000)
One of the warning message in gnttab_grow_table() refers to a function
was removed in commit 6425f91c72 "xen/gnttab: Fold grant_table_{create,
set_limits}() into grant_table_init()".

Since the commit, gt->active will be allocated while initializing the
grant table at domain creation. Therefore gt-active will always be
valid.

Rather than replacing the warning by another one, drop the check
completely as we will likely not come back to a semi-initialized world.

Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/common/grant_table.c

index bc37acae0e19cce9758b2e0013ec69806222af7d..057c78f620523732567b5c1d6ca7e77351e12f7a 100644 (file)
@@ -1793,12 +1793,6 @@ gnttab_grow_table(struct domain *d, unsigned int req_nr_frames)
     struct grant_table *gt = d->grant_table;
     unsigned int i, j;
 
-    if ( unlikely(!gt->active) )
-    {
-        gprintk(XENLOG_WARNING, "grant_table_set_limits() call missing\n");
-        return -ENODEV;
-    }
-
     if ( req_nr_frames < INITIAL_NR_GRANT_FRAMES )
         req_nr_frames = INITIAL_NR_GRANT_FRAMES;
     ASSERT(req_nr_frames <= gt->max_grant_frames);