]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
libcacard: Convert two leftover realloc() to GLib
authorMarkus Armbruster <armbru@redhat.com>
Fri, 23 May 2014 11:24:37 +0000 (13:24 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 23 May 2014 20:46:20 +0000 (00:46 +0400)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
libcacard/cac.c
libcacard/vcard_emul_nss.c

index 122129ec14773ef4f285844caa0bb55133f7d28c..3887896c5830ab46a09245adb6d54edf1aedc2fb 100644 (file)
@@ -169,17 +169,8 @@ cac_applet_pki_process_apdu(VCard *card, VCardAPDU *apdu,
         }
         size = apdu->a_Lc;
 
-        sign_buffer = realloc(pki_applet->sign_buffer,
-                      pki_applet->sign_buffer_len+size);
-        if (sign_buffer == NULL) {
-            g_free(pki_applet->sign_buffer);
-            pki_applet->sign_buffer = NULL;
-            pki_applet->sign_buffer_len = 0;
-            *response = vcard_make_response(
-                            VCARD7816_STATUS_EXC_ERROR_MEMORY_FAILURE);
-            ret = VCARD_DONE;
-            break;
-        }
+        sign_buffer = g_realloc(pki_applet->sign_buffer,
+                                pki_applet->sign_buffer_len + size);
         memcpy(sign_buffer+pki_applet->sign_buffer_len, apdu->a_body, size);
         size += pki_applet->sign_buffer_len;
         switch (apdu->a_p1) {
index 78265932fa6b09e117034297891aa1c71dcfcd77..8e055517f811cb96952928d1906bdb34c1a7f8fe 100644 (file)
@@ -1178,11 +1178,8 @@ vcard_emul_options(const char *args)
 
             if (opts->vreader_count >= reader_count) {
                 reader_count += READER_STEP;
-                vreaderOpt = realloc(opts->vreader,
-                                reader_count * sizeof(*vreaderOpt));
-                if (vreaderOpt == NULL) {
-                    return opts; /* we're done */
-                }
+                vreaderOpt = g_renew(VirtualReaderOptions, opts->vreader,
+                                     reader_count);
             }
             opts->vreader = vreaderOpt;
             vreaderOpt = &vreaderOpt[opts->vreader_count];