]> xenbits.xensource.com Git - pvdrivers/win/xenvif.git/commitdiff
Always log during SettingsRestore
authorOwen Smith <owen.smith@cloud.com>
Fri, 12 May 2023 13:56:45 +0000 (14:56 +0100)
committerPaul Durrant <pdurrant@amazon.com>
Mon, 22 May 2023 12:51:47 +0000 (13:51 +0100)
- removes the logging skip if the Settings key is not present
- logs if the interface guid doesnt change

Signed-off-by: Owen Smith <owen.smith@cloud.com>
src/xenvif/settings.c

index dd3c991b8b276dd718b845bb962b6cde36bc7a93..4dd4ec4742d6cdfac52fe3a1ff34be4bbdc0d62f 100644 (file)
@@ -622,12 +622,8 @@ SettingsRestore(
                                 SubKeyName,
                                 KEY_READ,
                                 &SubKey);
-    if (!NT_SUCCESS(status)) {
-        if (status == STATUS_OBJECT_NAME_NOT_FOUND)
-            goto done;
-
+    if (!NT_SUCCESS(status))
         goto fail1;
-    }
 
     status = RegistryQuerySzValue(SubKey,
                                   "NetCfgInstanceId",
@@ -658,6 +654,10 @@ SettingsRestore(
                      NetLuid,
                      &Ansi,
                      InterfaceLuid);
+    } else {
+        Info("%s: SettingsCopy not required for %ws\n",
+             SubKeyName,
+             Description);
     }
 
     RtlFreeAnsiString(&Ansi);
@@ -669,7 +669,6 @@ SettingsRestore(
 
     RegistryCloseKey(SubKey);
 
-done:
     return STATUS_SUCCESS;
 
 fail4: