]> xenbits.xensource.com Git - libvirt.git/commitdiff
Avoid empty strings when --with-packager(-version) is not specified
authorMatthias Bolte <matthias.bolte@googlemail.com>
Tue, 15 Feb 2011 18:48:44 +0000 (19:48 +0100)
committerMatthias Bolte <matthias.bolte@googlemail.com>
Tue, 15 Feb 2011 18:48:44 +0000 (19:48 +0100)
Make with_packager and with_packager_version default to "no". This way
--without-packager-version (as shorthand for --with-packager(-version)=no)
works correctly too.

Prior to this patch libvirt outputs a line like this when
--with-packager(-version) was not specified

# ./daemon/libvirtd
14:11:15.018: 31796: info : libvirt version: 0.8.8, package:  ()

Now the unspecified parts are correctly omitted.

Reported by Osier Yang.

configure.ac

index 3cd824afb1272499ebaabb363ba6842df507ce4d..9caa902fa90295f3adca13f73a6c6f9fadba3fad 100644 (file)
@@ -32,11 +32,11 @@ AC_SUBST([LIBVIRT_VERSION_NUMBER])
 AC_ARG_WITH([packager],
             [AS_HELP_STRING([--with-packager],
                             [Extra packager name])],
-            [],[])
+            [],[with_packager=no])
 AC_ARG_WITH([packager-version],
             [AS_HELP_STRING([--with-packager-version],
                             [Extra packager version])],
-            [],[])
+            [],[with_packager_version=no])
 if test "x$with_packager" != "xno"
 then
   AC_DEFINE_UNQUOTED([PACKAGER], ["$with_packager"],