]> xenbits.xensource.com Git - xen.git/commitdiff
x86/vmx: Fix label name in vmwrite_safe()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 28 Apr 2025 16:39:18 +0000 (17:39 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 2 May 2025 13:12:10 +0000 (14:12 +0100)
This condition is called VMFail(valid) in the SDM.

No functional change.

Fixes: fc3db01db6fb ("x86/vmx: Rework VMX wrappers using `asm goto()`")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/include/asm/hvm/vmx/vmx.h

index cc8c53fab149c0ebe996874ae09be492bdedabfb..d85b52b9d5225a0f0a93072dda3a9e00aa2eb7d0 100644 (file)
@@ -382,17 +382,17 @@ static inline enum vmx_insn_errno vmwrite_safe(unsigned long field,
 {
     asm goto ( "vmwrite %[value], %[field]\n\t"
                "jc %l[vmfail_invalid]\n\t"
-               "jz %l[vmfail_error]"
+               "jz %l[vmfail_valid]"
                :
                : [field] "r" (field), [value] "rm" (value)
                :
-               : vmfail_invalid, vmfail_error );
+               : vmfail_invalid, vmfail_valid );
     return VMX_INSN_SUCCEED;
 
  vmfail_invalid:
     return VMX_INSN_FAIL_INVALID;
 
- vmfail_error:
+ vmfail_valid:
     return vmread(VM_INSTRUCTION_ERROR);
 }