]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
libxl: initialize sdl.opengl defbool in libxlMakeVfb
authorJim Fehlig <jfehlig@suse.com>
Fri, 24 Apr 2015 20:11:26 +0000 (14:11 -0600)
committerJim Fehlig <jfehlig@suse.com>
Fri, 24 Apr 2015 20:11:26 +0000 (14:11 -0600)
Commit bf32462b missed initializing sdl.opengl.  Without the
initialization, libvirtd will be terminated by an assert from libxl:

Assertion `!libxl_defbool_is_default(db)' failed.

Reported-by: Olaf Hering <olaf@aepfle.de>
src/libxl/libxl_conf.c

index 55bd21b8d4a6a2a1f1798129a88f6f4da110a063..53f327bd10281b9fc358c71578f0c1fd67e4c093 100644 (file)
@@ -1243,6 +1243,7 @@ libxlMakeVfb(virPortAllocatorPtr graphicsports,
         case VIR_DOMAIN_GRAPHICS_TYPE_SDL:
             libxl_defbool_set(&x_vfb->sdl.enable, 1);
             libxl_defbool_set(&x_vfb->vnc.enable, 0);
+            libxl_defbool_set(&x_vfb->sdl.opengl, 0);
             if (VIR_STRDUP(x_vfb->sdl.display, l_vfb->data.sdl.display) < 0)
                 return -1;
             if (VIR_STRDUP(x_vfb->sdl.xauthority, l_vfb->data.sdl.xauth) < 0)