]> xenbits.xensource.com Git - xen.git/commitdiff
-xen-attach is needed for pvh boot with qemu-xen 4.8.3pre-shim-comet 4.8.3pre-shim-comet-2
authorMichael Young <m.a.young@durham.ac.uk>
Mon, 15 Jan 2018 21:23:20 +0000 (21:23 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 16 Jan 2018 16:38:15 +0000 (16:38 +0000)
Currently the boot of a pvh guest using the qemu-xen device model fails
with the error
xen emulation not implemented (yet)
in the qemu-dm log file. This patch adds the missing -xen-attach
argument.

V2: Use  b_info->type != LIBXL_DOMAIN_TYPE_HVM    instead of
  (b_info->type == LIBXL_DOMAIN_TYPE_PV) ||
  (b_info->type == LIBXL_DOMAIN_TYPE_PVH)
as recommended by Roger Pau MonnĂ©.

Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
(cherry picked from commit 6f1979c8e4184f1f2b24b860e30d3b037b2e7f05)

tools/libxl/libxl_dm.c

index 5306623649492c3dd52769c2da360e3ab9e832d5..c8b033286e4bf8995e21a63426e0886bf87f9578 100644 (file)
@@ -991,7 +991,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
      */
     flexarray_append(dm_args, "-no-user-config");
 
-    if (b_info->type == LIBXL_DOMAIN_TYPE_PV) {
+    if (b_info->type != LIBXL_DOMAIN_TYPE_HVM) {
         flexarray_append(dm_args, "-xen-attach");
     }