conf: Use virTristateXXX in virDomainLoaderDef

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c02d469e78516a07f9aae475a44edbcbc0ec5f50..a0fb7731d9f4ad238f84a3832080c6d8ec9259ae 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -19221,18 +19221,24 @@ virDomainLoaderDefParseXML(xmlNodePtr node,
             VIR_FREE(loader->path);
     }
 
-    if (readonly_str &&
-        (loader->readonly = virTristateBoolTypeFromString(readonly_str)) <= 0) {
-        virReportError(VIR_ERR_XML_DETAIL,
-                       _("unknown readonly value: %s"), readonly_str);
-        return -1;
+    if (readonly_str) {
+        int value;
+        if ((value = virTristateBoolTypeFromString(readonly_str)) <= 0) {
+            virReportError(VIR_ERR_XML_DETAIL,
+                           _("unknown readonly value: %s"), readonly_str);
+            return -1;
+        }
+        loader->readonly = value;
     }
 
-    if (secure_str &&
-        (loader->secure = virTristateBoolTypeFromString(secure_str)) <= 0) {
-        virReportError(VIR_ERR_XML_DETAIL,
-                       _("unknown secure value: %s"), secure_str);
-        return -1;
+    if (secure_str) {
+        int value;
+        if ((value = virTristateBoolTypeFromString(secure_str)) <= 0) {
+            virReportError(VIR_ERR_XML_DETAIL,
+                           _("unknown secure value: %s"), secure_str);
+            return -1;
+        }
+        loader->secure = value;
     }
 
     if (type_str) {

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a4c07d7dfb6358b8c630757c781063bcbb854c2b..f186922040b8960c12085a53c70ec51fc148fff6 100644 (file)
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2146,9 +2146,9 @@ VIR_ENUM_DECL(virDomainLoader);
 
 struct _virDomainLoaderDef {
     char *path;
-    int readonly;   /* enum virTristateBool */
+    virTristateBool readonly;
     virDomainLoader type;
-    int secure;     /* enum virTristateBool */
+    virTristateBool secure;
     char *nvram;    /* path to non-volatile RAM */
     char *templt;   /* user override of path to master nvram */
 };