]> xenbits.xensource.com Git - libvirt.git/commitdiff
vmware: avoid null deref on failed lookup
authorEric Blake <eblake@redhat.com>
Mon, 4 Jul 2011 02:32:22 +0000 (10:32 +0800)
committerDaniel Veillard <veillard@redhat.com>
Mon, 4 Jul 2011 02:32:22 +0000 (10:32 +0800)
* src/vmware/vmware_driver.c (vmwareDomainReboot): Check error
  before dereferencing memory.

src/vmware/vmware_driver.c

index 5e2c4ba6b5c094a9d7793c4ff3e5e765df5cab8b..52582d62819ad2c37740f2374babd709f6c5135e 100644 (file)
@@ -461,7 +461,6 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED)
     vmwareDriverLock(driver);
     vm = virDomainFindByUUID(&driver->domains, dom->uuid);
     vmwareDriverUnlock(driver);
-    vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath;
 
     if (!vm) {
         vmwareError(VIR_ERR_NO_DOMAIN, "%s",
@@ -469,6 +468,7 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED)
         goto cleanup;
     }
 
+    vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath;
     vmwareSetSentinal(cmd, vmw_types[driver->type]);
     vmwareSetSentinal(cmd, vmxPath);