]> xenbits.xensource.com Git - libvirt.git/commitdiff
Avoid free'ing a constant string in chardev lookup code
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 5 Jan 2010 11:51:04 +0000 (11:51 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 18 Jan 2010 13:33:50 +0000 (13:33 +0000)
 * src/qemu/qemu_monitor_text.c: Don't free const string in
   qemuMonitorTextGetPtyPaths()

src/qemu/qemu_monitor_text.c

index 52cd97ce1dc45860958dd7a39f43f5726a223e59..2b8c1e8f22b432ccdf1cd1f3395154718b799b63 100644 (file)
@@ -1678,14 +1678,12 @@ cleanup:
 int qemuMonitorTextGetPtyPaths(qemuMonitorPtr mon,
                                virHashTablePtr paths)
 {
-    const char *cmd = "info chardev";
     char *reply = NULL;
     int ret = -1;
 
-    if (qemuMonitorCommand(mon, cmd, &reply) < 0) {
-        qemudReportError(NULL, NULL, NULL, VIR_ERR_OPERATION_FAILED,
-                         _("failed to retrieve chardev info in qemu with '%s'"),
-                         cmd);
+    if (qemuMonitorCommand(mon, "info chardev", &reply) < 0) {
+        qemudReportError(NULL, NULL, NULL, VIR_ERR_OPERATION_FAILED, "%s",
+                         _("failed to retrieve chardev info in qemu with 'info chardev'"));
         goto cleanup;
     }
 
@@ -1747,7 +1745,6 @@ int qemuMonitorTextGetPtyPaths(qemuMonitorPtr mon,
     ret = 0;
 
 cleanup:
-    VIR_FREE(cmd);
     VIR_FREE(reply);
     return ret;
 }