]> xenbits.xensource.com Git - people/dwmw2/xen.git/commitdiff
tools/libfsimage: Add `XEN' to environment variable name
authorIan Jackson <ian.jackson@eu.citrix.com>
Tue, 5 Mar 2019 15:31:32 +0000 (15:31 +0000)
committerIan Jackson <ian.jackson@eu.citrix.com>
Tue, 5 Mar 2019 16:25:08 +0000 (16:25 +0000)
This library, which is private to Xen and was properly namespaced in
  1a814711881beb17f073f5f57e27e5bd4da1b956
  tools/libfsimage: Add `xen' to .h names and principal .so name
honours an environment variable to override the directory where
shared objects (ie filesystem plugins) are to be loaded from.

Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
it a proper namespace prefix.

Nothing in xen.git sets this variable.  The three hits for the string
`FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
manifest constant which provides the default value (the -D which sets
it, and the place it is used).

I have also checked the current Debian Xen package in buster and the
variable is not set there either.

CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: George Dunlap <george.dunlap@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
tools/libfsimage/common/fsimage_plugin.c

index 44ebcf31427fa8ffb694ea0ec8835c7a18fa0c09..de1412b4233ab112cf9100ab41178b110c46d48c 100644 (file)
@@ -121,7 +121,7 @@ fail:
 
 static int load_plugins(void)
 {
-       const char *fsdir = getenv("FSIMAGE_FSDIR");
+       const char *fsdir = getenv("XEN_FSIMAGE_FSDIR");
        struct dirent *dp = NULL;
        DIR *dir = NULL;
        char *tmp = NULL;