]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuBackupDiskStarted: Fix improper dereference of array
authorPeter Krempa <pkrempa@redhat.com>
Tue, 23 Jun 2020 05:44:45 +0000 (07:44 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 23 Jun 2020 09:23:01 +0000 (11:23 +0200)
The code would repeatedly mark the first disk's blockjob as started
rather than accessing all the blockjobs. Fix the dereferencing operator.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_backup.c

index 43fe8942ad94e6ed0ed9db71c603289a99787395..ab9cd2689ff8efc1fe9634742f0000b82c6283ed 100644 (file)
@@ -482,7 +482,7 @@ qemuBackupDiskStarted(virDomainObjPtr vm,
     for (i = 0; i < ndd; i++) {
         dd[i].started = true;
         dd[i].backupdisk->state = VIR_DOMAIN_BACKUP_DISK_STATE_RUNNING;
-        qemuBlockJobStarted(dd->blockjob, vm);
+        qemuBlockJobStarted(dd[i].blockjob, vm);
     }
 }