conf: error out for multiple protocol elements while parsing chardev

Remove check whether a variable was already set because the element
is parsed only once now.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 7431de20dac0794eac1437f3a9e1d0dd9e976d6f..36c8c77f7edad95c8dc9a497add45d6dbc28230a 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -10926,6 +10926,7 @@ virDomainChrSourceDefParseXML(virDomainChrSourceDefPtr def,
     char *haveTLS = NULL;
     char *tlsFromConfig = NULL;
     bool logParsed = false;
+    bool protocolParsed = false;
     int sourceParsed = 0;
 
     for (; cur; cur = cur->next) {
@@ -11040,8 +11041,14 @@ virDomainChrSourceDefParseXML(virDomainChrSourceDefPtr def,
             logfile = virXMLPropString(cur, "file");
             logappend = virXMLPropString(cur, "append");
         } else if (virXMLNodeNameEqual(cur, "protocol")) {
-            if (!protocol)
-                protocol = virXMLPropString(cur, "type");
+            if (protocolParsed) {
+                virReportError(VIR_ERR_XML_ERROR, "%s",
+                               _("only one log element is allowed for "
+                                 "character device"));
+                goto error;
+            }
+            protocolParsed = true;
+            protocol = virXMLPropString(cur, "type");
         }
     }