]> xenbits.xensource.com Git - libvirt.git/commitdiff
storage: sheepdog: Avoid skipping variable initialization
authorPeter Krempa <pkrempa@redhat.com>
Mon, 2 Mar 2015 09:09:49 +0000 (10:09 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 2 Mar 2015 09:09:49 +0000 (10:09 +0100)
Commit 155ca616eb231181f6978efc9e3a1eb0eb60af8a added a error message
that skips initialization of the 'cmd' variable. Fortunately it was not
released.

src/storage/storage_backend_sheepdog.c

index f389d9bc53c4c542efec6da4a6d634c83868671e..af15c3b1e2b9b1f4bf05a96c9236219eb2b8453e 100644 (file)
@@ -263,6 +263,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
                                   unsigned int flags)
 {
     int ret = -1;
+    virCommandPtr cmd = NULL;
 
     virCheckFlags(0, -1);
 
@@ -272,7 +273,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
         goto cleanup;
     }
 
-    virCommandPtr cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);
+    cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);
     virCommandAddArgFormat(cmd, "%llu", vol->target.capacity);
     virStorageBackendSheepdogAddHostArg(cmd, pool);
     if (virCommandRun(cmd, NULL) < 0)