qemu: command: Move disk serial validation to qemuCheckDiskConfig

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1c8e3d6838f72bb20348aea5ebcbe8a9bed7dd41..2fe4ae380a051092d278c1e4286dc17f21152948 100644 (file)
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1429,6 +1429,10 @@ qemuCheckDiskConfig(virDomainDiskDefPtr disk,
         }
     }
 
+    if (disk->serial &&
+        qemuSafeSerialParamValue(disk->serial) < 0)
+        return -1;
+
     return 0;
 }
 
@@ -1714,8 +1718,6 @@ qemuBuildDriveStr(virDomainDiskDefPtr disk,
 
     if (disk->serial &&
         virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_SERIAL)) {
-        if (qemuSafeSerialParamValue(disk->serial) < 0)
-            goto error;
         virBufferAddLit(&opt, ",serial=");
         virBufferEscape(&opt, '\\', " ", "%s", disk->serial);
     }