]> xenbits.xensource.com Git - people/dwmw2/xen.git/commitdiff
xen/char: scif-uart: Remove useless ASSERT condition
authorArtem Mygaiev <joculator@gmail.com>
Wed, 9 Oct 2019 14:20:16 +0000 (17:20 +0300)
committerJulien Grall <julien@xen.org>
Sat, 18 Jan 2020 12:57:15 +0000 (12:57 +0000)
cnt is unsigned, so always >=0

Coverity-ID: 1381848
Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
[julien: Update commit title]
Acked-by: Julien Grall <julien@xen.org>
xen/drivers/char/scif-uart.c

index fa0b8274ca40237a015634ebe8f77fed091c1a0e..9d3f66b55b673fdafec73d55391329ec28ba5a64 100644 (file)
@@ -205,7 +205,7 @@ static int scif_uart_tx_ready(struct serial_port *port)
 
      /* Check number of data bytes stored in TX FIFO */
     cnt = scif_readw(uart, SCIF_SCFDR) >> 8;
-    ASSERT( cnt >= 0 && cnt <= params->fifo_size );
+    ASSERT( cnt <= params->fifo_size );
 
     return (params->fifo_size - cnt);
 }