]> xenbits.xensource.com Git - mini-os.git/commitdiff
mini-os: fix double free() in netfront
authorJuergen Gross <jgross@suse.com>
Thu, 9 Apr 2020 14:12:38 +0000 (16:12 +0200)
committerWei Liu <liuw@liuw.name>
Thu, 9 Apr 2020 14:40:10 +0000 (15:40 +0100)
Commit d225f4012d69a19 ("Save/Restore Support: Add suspend/restore
support for netfront") introduced a regression in form of freeing a
netfront device structure twice.

Fix that.

Coverity-ID: 1433637
Fixes: d225f4012d69a19 ("Save/Restore Support: Add suspend/restore support for netfront")
Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wl@xen.org>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
netfront.c

index 50b3a576fae21e5f13c4c73a12cb1b09917f3aa3..fe7bb6287ed82f368fff2382958a8592fe050a78 100644 (file)
@@ -584,8 +584,6 @@ void shutdown_netfront(struct netfront_dev *dev)
     list->refcount--;
     if (list->refcount == 0) {
         _shutdown_netfront(dev);
-        free(dev->nodename);
-        free(dev);
 
         to_del = list;
         if (to_del == dev_list) {