]> xenbits.xensource.com Git - libvirt.git/commitdiff
ci: helper: Drop the --meson-args/--ninja-args CLI options
authorErik Skultety <eskultet@redhat.com>
Fri, 25 Aug 2023 16:03:48 +0000 (18:03 +0200)
committerErik Skultety <eskultet@redhat.com>
Tue, 12 Sep 2023 09:36:03 +0000 (11:36 +0200)
These originally allowed customizing the ci/Makefile script which was
the core of the local container executions. The problem was that
however flexible this may have been, it never mirrored what was being
done as part of the GitLab jobs. Motivated by the effort of mirroring
GitLab jobs locally, these would only ever make sense to be set/used in
interactive shell container sessions where the developer is perfectly
capable of using the right meson/ninja CLI options directly without
going through another shell variable indirection as it was the case
with these ci/helper options.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
ci/helper

index b90dc56ede417c17021f73d63c5e047f30f17f4d..c734629731794d4d2787321e520f2352617a87de 100755 (executable)
--- a/ci/helper
+++ b/ci/helper
@@ -75,21 +75,6 @@ class Parser:
             help="path to lcitool (default: $PATH)",
         )
 
-        # Options that are common to all actions that call the
-        # project's build system
-        mesonparser = argparse.ArgumentParser(add_help=False)
-        mesonparser.add_argument(
-            "--meson-args",
-            default="",
-            help="additional arguments passed to meson "
-                 "(eg --meson-args='-Dopt1=enabled -Dopt2=disabled')",
-        )
-        mesonparser.add_argument(
-            "--ninja-args",
-            default="",
-            help="additional arguments passed to ninja",
-        )
-
         # Options that are common to actions communicating with a GitLab
         # instance
         gitlabparser = argparse.ArgumentParser(add_help=False)