]> xenbits.xensource.com Git - xen.git/commitdiff
arm: p2m: Prevent redundant icache flushes
authorPunit Agrawal <punit.agrawal@arm.com>
Fri, 26 May 2017 11:14:06 +0000 (12:14 +0100)
committerStefano Stabellini <sstabellini@kernel.org>
Fri, 7 Jul 2017 18:00:22 +0000 (11:00 -0700)
When toolstack requests flushing the caches, flush_page_to_ram() is
called for each page of the requested domain. This needs to unnecessary
icache invalidation operations.

Let's take the responsibility of performing icache operations and use
the recently introduced flag to prevent redundant icache operations by
flush_page_to_ram().

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
(cherry picked from commit 1a0c3e3e28d6cd072734990efcaaec608bf152b1)

xen/arch/arm/p2m.c

index 8b6b150cab201de7f9c2e30395babf56549db8cb..720ef13bac01404042c624038d99d68b7a3227dc 100644 (file)
@@ -1469,13 +1469,15 @@ int p2m_cache_flush(struct domain *d, gfn_t start, unsigned long nr)
         /* XXX: Implement preemption */
         while ( gfn_x(start) < gfn_x(next_gfn) )
         {
-            flush_page_to_ram(mfn_x(mfn), true);
+            flush_page_to_ram(mfn_x(mfn), false);
 
             start = gfn_add(start, 1);
             mfn = mfn_add(mfn, 1);
         }
     }
 
+    invalidate_icache();
+
     p2m_read_unlock(p2m);
 
     return 0;