convert-cabinet-layout: generalise setprop (nfc)

diff --git a/convert-cabinet-layout b/convert-cabinet-layout
index 978cc4098e37336c4f10fadde1c1004510b660da..0546e016858851d0d9a4911839fdf1c312a21304 100755 (executable)
--- a/convert-cabinet-layout
+++ b/convert-cabinet-layout
@@ -59,6 +59,12 @@ sub outfor ($$) {
     $outfor{$dest} .= $s;
 }
 
+sub setprop ($$) {
+    my ($prop,$value) = @_;
+    outfor 'mg-hosts setprops $prop',
+        "./mg-hosts setprops $machine -- $prop '$value'\n";
+}
+
 while (my $row = $csv->getline_hr($fh)) {
     print DEBUG Dumper($row);
 
@@ -88,9 +94,7 @@ while (my $row = $csv->getline_hr($fh)) {
         my ($pdu,$port);
         if ($pdu1) { $pdu='pdu1'; $port=$pdu1; }
         if ($pdu2) { $pdu='pdu2'; $port=$pdu2; }
-        outfor 'mg-hosts setprops PowerMethod',
-        sprintf "./mg-hosts setprops %s -- PowerMethod 'msw --apc6 %s %d'\n",
-            $machine, $pdu, $port;
+        setprop 'PowerMethod', "msw --apc6 $pdu $port";
     }
 }