qemuBuildHostNetStr: Explicitly enumerate net types

We tend to prevent using 'default' in switches. And it is for a
good reason - control may end up in paths we wouldn't want for
new values. In this specific case, if qemuBuildHostNetStr is
called over VIR_DOMAIN_NET_TYPE_VHOSTUSER it would produce
meaningless output. Fortunately, there no such call yet.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index d323b538d3221c5bbc8f31af082334cb09746ca6..5213e9704fcb2fb8d40e2a20d2711a8bbb7a3b33 100644 (file)
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3723,9 +3723,21 @@ qemuBuildHostNetStr(virDomainNetDefPtr net,
         break;
 
     case VIR_DOMAIN_NET_TYPE_USER:
-    default:
+    case VIR_DOMAIN_NET_TYPE_INTERNAL:
         virBufferAddLit(&buf, "user");
         break;
+
+    case VIR_DOMAIN_NET_TYPE_HOSTDEV:
+        /* Should have been handled earlier via PCI/USB hotplug code. */
+        virObjectUnref(cfg);
+        return NULL;
+
+    case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
+        /* Unsupported yet. */
+        break;
+
+    case VIR_DOMAIN_NET_TYPE_LAST:
+        break;
     }
 
     if (vlan >= 0) {