]> xenbits.xensource.com Git - xen.git/commitdiff
rombios/tcgbios: initialise entry in HashLogEvent32
authorWei Liu <wei.liu2@citrix.com>
Fri, 29 Apr 2016 15:11:13 +0000 (16:11 +0100)
committerWei Liu <wei.liu2@citrix.com>
Fri, 6 May 2016 14:50:15 +0000 (15:50 +0100)
Gcc complains:

tcgbios.c:1142:22: error: ‘entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    hleo->eventnumber = entry;

It fails to figure out if entry is used it is always initialised in
previous if block.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
tools/firmware/rombios/32bit/tcgbios/tcgbios.c

index d1d1203f5d0bc7b080de0ecbff5b2db56a1633e3..350105107c07270a9c3fd8caee0888e85284776f 100644 (file)
@@ -1100,7 +1100,7 @@ uint32_t HashLogEvent32(struct hlei *hlei, struct hleo *hleo,
        }
 
        if (rc == 0) {
-               uint32_t entry;
+               uint32_t entry = 0;
                hashdataptr = hlei->hashdataptr;
                hashdatalen = hlei->hashdatalen;