In C99 (7.19.6.2.10), the behavior of scanf("stuff... %n", ..., &n) is

said to be undefined if the value to be put is n can't fit.  I guess
we can safely consider that the same applies to printf.

Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>
xen-unstable changeset:   16671:19f549449cb5
xen-unstable date:        Fri Dec 28 15:23:28 2007 +0000

diff --git a/extras/mini-os/lib/printf.c b/extras/mini-os/lib/printf.c
index 676f4e74a1bf66ebc2b4aa43dac4fef71b6218bd..a6767e48adcb96fc13d16d81fb9b89054d361fe3 100644 (file)
--- a/extras/mini-os/lib/printf.c
+++ b/extras/mini-os/lib/printf.c
@@ -426,8 +426,6 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
 
 
         case 'n':
-            /* FIXME:
-             * What does C99 say about the overflow case here? */
             if (qualifier == 'l') {
                 long * ip = va_arg(args, long *);
                 *ip = (str - buf);
@@ -446,7 +444,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
             ++str;
             continue;
 
-                        /* integer number formats - set up the flags and "break" */
+            /* integer number formats - set up the flags and "break" */
         case 'o':
             base = 8;
             break;

diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c
index 355305fa5738e0ec8322819e2cb13e20353a825f..0c2ed4501818a7ee795dc86e57b4a869a7d7f207 100644 (file)
--- a/xen/common/vsprintf.c
+++ b/xen/common/vsprintf.c
@@ -404,8 +404,6 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
 
 
         case 'n':
-            /* FIXME:
-             * What does C99 say about the overflow case here? */
             if (qualifier == 'l') {
                 long * ip = va_arg(args, long *);
                 *ip = (str - buf);
@@ -424,7 +422,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
             ++str;
             continue;
 
-                        /* integer number formats - set up the flags and "break" */
+            /* integer number formats - set up the flags and "break" */
         case 'o':
             base = 8;
             break;