]> xenbits.xensource.com Git - libvirt.git/commitdiff
ch: Demote error when CH driver fails to init
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 8 Mar 2024 14:12:15 +0000 (15:12 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 12 Mar 2024 16:38:10 +0000 (17:38 +0100)
If the host doesn't have /dev/kvm nor /dev/mshv, i.e. CH driver
is unable to run any guests, then an error is reported. But the
usual thing to do here is print an info message into the logs and
return VIR_DRV_STATE_INIT_SKIPPED. It is a recoverable error
after all.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/ch/ch_driver.c

index 2601eea44b0610a0b8efbc7c917aa7651a93f8a5..9394924f2dec89830aae577576033b5e691e5771 100644 (file)
@@ -893,9 +893,8 @@ static int chStateInitialize(bool privileged,
                                         VIR_ARCH_NONE, VIR_DOMAIN_VIRT_KVM) &&
         !virCapabilitiesDomainSupported(ch_driver->caps, -1,
                                         VIR_ARCH_NONE, VIR_DOMAIN_VIRT_HYPERV)) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("/dev/kvm and /dev/mshv are missing. CH driver failed to initialize."));
-        return VIR_DRV_STATE_INIT_ERROR;
+        VIR_INFO("/dev/kvm and /dev/mshv are missing. CH driver failed to initialize.");
+        return VIR_DRV_STATE_INIT_SKIPPED;
     }
 
     if (!(ch_driver->xmlopt = chDomainXMLConfInit(ch_driver)))