]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: Don't require 'def' in virDomainDiskDefParse
authorPeter Krempa <pkrempa@redhat.com>
Fri, 16 Mar 2018 14:32:09 +0000 (15:32 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 3 Apr 2018 13:48:37 +0000 (15:48 +0200)
In some use cases (mostly in tests) it is not required to check the
seclabel definition validity. Add possibility to call
virDomainDiskDefParse without the domain definition.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
src/conf/domain_conf.c

index e2bad48cc887003c4241da75318bdf5077ca5724..ac3a3d9966f0679126066fa646c5d4e0b35bb6d5 100644 (file)
@@ -15873,6 +15873,8 @@ virDomainDiskDefParse(const char *xmlStr,
     xmlDocPtr xml;
     xmlXPathContextPtr ctxt = NULL;
     virDomainDiskDefPtr disk = NULL;
+    virSecurityLabelDefPtr *seclabels = NULL;
+    size_t nseclabels = 0;
 
     if (!(xml = virXMLParseStringCtxt(xmlStr, _("(disk_definition)"), &ctxt)))
         goto cleanup;
@@ -15884,10 +15886,13 @@ virDomainDiskDefParse(const char *xmlStr,
         goto cleanup;
     }
 
+    if (def) {
+        seclabels = def->seclabels;
+        nseclabels = def->nseclabels;
+    }
+
     disk = virDomainDiskDefParseXML(xmlopt, ctxt->node, ctxt,
-                                    NULL, def->seclabels,
-                                    def->nseclabels,
-                                    flags);
+                                    NULL, seclabels, nseclabels, flags);
 
  cleanup:
     xmlFreeDoc(xml);