nwfilter: Do not require DHCP requests to be broadcasted

Remove the requirement that DHCP messages have to be broadcasted.
DHCP requests are most often sent via broadcast but can be directed
towards a specific DHCP server. For example 'dhclient' takes '-s <server>'
as a command line parameter thus allowing DHCP requests to be sent to a
specific DHCP server.

diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c
index d8b1e9798ad2879e0ba23f079e91597585824d89..9c244be41c697ebba4440256ace39d47b72b885e 100644 (file)
--- a/src/nwfilter/nwfilter_ebiptables_driver.c
+++ b/src/nwfilter/nwfilter_ebiptables_driver.c
@@ -3245,9 +3245,8 @@ ebtablesApplyDHCPOnlyRules(const char *ifname,
 
     virBufferAsprintf(&buf,
                       CMD_DEF("$EBT -t nat -A %s"
-                              " -s %s -d Broadcast "
+                              " -s %s"
                               " -p ipv4 --ip-protocol udp"
-                              " --ip-src 0.0.0.0 --ip-dst 255.255.255.255"
                               " --ip-sport 68 --ip-dport 67"
                               " -j ACCEPT") CMD_SEPARATOR
                       CMD_EXEC