]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commitdiff
dump: Abstract dump_init() with cpu_synchronize_all_states()
authorAndreas Färber <afaerber@suse.de>
Sun, 9 Jun 2013 14:48:29 +0000 (16:48 +0200)
committerAndreas Färber <afaerber@suse.de>
Tue, 11 Jun 2013 17:01:39 +0000 (19:01 +0200)
Instead of calling cpu_synchronize_state() for each CPU, call the
existing cpu_synchronize_all_states() helper.

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
dump.c

diff --git a/dump.c b/dump.c
index c0d3da515b6c083b41819564d867c4bafb12dc24..87ca12cee0379b417571308113f1541fff8e8842 100644 (file)
--- a/dump.c
+++ b/dump.c
@@ -21,6 +21,7 @@
 #include "sysemu/dump.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/memory_mapping.h"
+#include "sysemu/cpus.h"
 #include "qapi/error.h"
 #include "qmp-commands.h"
 
@@ -731,12 +732,12 @@ static int dump_init(DumpState *s, int fd, bool paging, bool has_filter,
      * If the target architecture is not supported, cpu_get_dump_info() will
      * return -1.
      *
-     * if we use kvm, we should synchronize the register before we get dump
+     * If we use KVM, we should synchronize the registers before we get dump
      * info.
      */
+    cpu_synchronize_all_states();
     nr_cpus = 0;
     for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu_synchronize_state(env);
         nr_cpus++;
     }