]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
platforms/xgene: Make use of dt_device_get_address return value
authorMichal Orzel <michal.orzel@arm.com>
Wed, 27 Apr 2022 09:49:39 +0000 (11:49 +0200)
committerStefano Stabellini <stefano.stabellini@xilinx.com>
Wed, 27 Apr 2022 22:23:09 +0000 (15:23 -0700)
Currently function xgene_check_pirq_eoi assigns the return value of
dt_device_get_address to a variable res but does not make use of it.
Fix it by making use of res in the condition checking the result of a
call to dt_device_get_address instead of checking the address stored in
dbase.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
xen/arch/arm/platforms/xgene-storm.c

index fced4d7c2c1a46fa6f5dca1dd8429afd328c30e3..befd0c3c2d463722a7bdeb6a66e6d950dbff24ce 100644 (file)
@@ -51,7 +51,7 @@ static void __init xgene_check_pirq_eoi(void)
         panic("%s: Can not find interrupt controller node\n", __func__);
 
     res = dt_device_get_address(node, 0, &dbase, NULL);
-    if ( !dbase )
+    if ( res )
         panic("%s: Cannot find a valid address for the distributor\n", __func__);
 
     /*