]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainBackupDiskDefFormat: Format internal disk state only when valid
authorPeter Krempa <pkrempa@redhat.com>
Tue, 7 Jul 2020 14:52:50 +0000 (16:52 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 8 Jul 2020 06:40:30 +0000 (08:40 +0200)
Format the disk state only when it isn't _NONE.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
src/conf/backup_conf.c

index 781dd53f6bbf062192d5c034cefeae3b37e64d16..5e4144d37103d9e4bbc83f02c895e46a6d913910 100644 (file)
@@ -370,7 +370,7 @@ virDomainBackupDiskDefFormat(virBufferPtr buf,
 
     virBufferEscapeString(&attrBuf, " name='%s'", disk->name);
     virBufferAsprintf(&attrBuf, " backup='%s'", virTristateBoolTypeToString(disk->backup));
-    if (internal)
+    if (internal && disk->state != VIR_DOMAIN_BACKUP_DISK_STATE_NONE)
         virBufferAsprintf(&attrBuf, " state='%s'", virDomainBackupDiskStateTypeToString(disk->state));
 
     if (disk->backup == VIR_TRISTATE_BOOL_YES) {