]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
do not lock vm while allocating memory
authorWen Congyang <wency@cn.fujitsu.com>
Wed, 30 Mar 2011 07:46:33 +0000 (15:46 +0800)
committerWen Congyang <ghostwcy@gmail.com>
Sun, 3 Apr 2011 01:13:46 +0000 (09:13 +0800)
There is no need to lock vm while allocating memory. If allocating
memory failed, we forgot to unlock vm.

src/qemu/qemu_process.c

index 2fc2b6c6a468ad7f38c1b59f3370fd119d26f83c..6c5ae2f702a93d49b76c59abedd87f370af7fdd7 100644 (file)
@@ -525,8 +525,6 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
     virDomainEventGraphicsSubjectPtr subject = NULL;
     int i;
 
-    virDomainObjLock(vm);
-
     if (VIR_ALLOC(localAddr) < 0)
         goto no_memory;
     localAddr->family = localFamily;
@@ -560,6 +558,7 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
         subject->nidentity++;
     }
 
+    virDomainObjLock(vm);
     event = virDomainEventGraphicsNewFromObj(vm, phase, localAddr, remoteAddr, authScheme, subject);
     virDomainObjUnlock(vm);